platforms/joystick: replace sdl with 0xcafed00d/joystick package #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed00d package Signed-off-by: deadprogram <[email protected]>
…ID as is now required Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #988 +/- ##
=======================================
Coverage 71.50% 71.50%
=======================================
Files 88 88
Lines 7352 7352
=======================================
Hits 5257 5257
Misses 1475 1475
Partials 620 620 ☔ View full report in Codecov by Sentry. |
deadprogram
force-pushed
the
joystick-no-sdl
branch
from
0e2a874
to
7daf724
Compare
…at since it is not handled in the current joystick package Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
deadprogram
force-pushed
the
joystick-no-sdl
branch
from
22347b2
to
2a352ed
Compare
…erences Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
gen2thomas
reviewed
Sep 14, 2023
| d := initTestDriver("./configs/xbox360_power_a_mini_proex.json") | ||
| _ = d.Start() | ||
| d, tj := initTestDriver("./configs/dualshock3.json") | ||
| tj.axisCount = 6 |
There was a problem hiding this comment.
Suggested change
| tj.axisCount = 6 | |
| tj.axisCount = 6 // corresponding to the content of json config |
Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
deadprogram
force-pushed
the
joystick-no-sdl
branch
from
aba55e1
to
22db6a5
Compare
Signed-off-by: deadprogram <[email protected]>
|
I've now also added the mappings for dualshock4. I don't have any working setup for any other joysticks then these 2 at the moment, but this should handle many people, and the new scanner will help handle the others for people who have those setups. |
|
@deadprogram nice work, I'm going to merge now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved issues and/or description of the change
This PR is to address #986 by replacing SDL with the much simpler package https://github.com/0xcafed00d/joystick
Manual test
Already tested Dualshock 3 on both Linux and macOS. Will test Windows this weekend.
Checklist
make test)make fmt_check)