ble: simplify and substitute errors.Wrap() #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jney
reviewed
Jul 6, 2023
| "os" | ||
|
|
||
| "gobot.io/x/gobot/v2" | ||
|
|
||
| paho "github.com/eclipse/paho.mqtt.golang" | ||
| "github.com/pkg/errors" |
There was a problem hiding this comment.
yes, this would be also possible, but a good practice is to use one of "fmt.Errorf()" or "errors.New()" in one file (some say also in one project)
gen2thomas
added a commit
to gen2thomas/gobot
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved issues and/or description of the change
Archived package ""github.com/pkg/errors" now removed from gobot, see #952 . Additionally:
Manual test
no
Checklist
make test)make fmt_check)