Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mod: change package ioutil->os #923

Merged
merged 4 commits into from
Jun 10, 2023
Merged

mod: change package ioutil->os #923

merged 4 commits into from
Jun 10, 2023

Conversation

dlstjq7685
Copy link
Contributor

little change fs_mock.go.
ioutil is Deprecated, so i changed to os package.

@gen2thomas
Copy link
Collaborator

Hi @dlstjq7685 , thanks for preparation of the PR. Currently we are fighting with the download problem of gobot framework since v2+, so please be patient. No action is required, also no rebase at the moment.

After that phase I will have a look to your change. Meanwhile I can just say: there are some more usages for ioutil in the code and it would be nice if we can fix this all at once.

Thank you for your patience!

@gen2thomas gen2thomas self-requested a review May 28, 2023 17:43
@gen2thomas
Copy link
Collaborator

Hi @dlstjq7685 , dev branch is now open for merge again. Please could you also fix the other findings for ioutil.

Thanks Thomas

@dlstjq7685
Copy link
Contributor Author

@gen2thomas
waiting for your comment.
please check this changes.

@gen2thomas
Copy link
Collaborator

Hi @dlstjq7685 , many thanks for your good work, please see my only comment regarding the conflict warning below.

@dlstjq7685
Copy link
Contributor Author

@gen2thomas
I was forgot merge current dev branch.
Please re-check commit files.

gen2thomas
gen2thomas approved these changes Jun 10, 2023
View reviewed changes
Copy link
Collaborator

@gen2thomas gen2thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

cli/generate.go Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file was removed now, please rebase your branch (or simply revert the change on this file)

@gen2thomas gen2thomas merged commit 8b20c45 into hybridgroup:dev Jun 10, 2023
@gen2thomas
Copy link
Collaborator

Nice work, thanks! Already merged.

gen2thomas pushed a commit to gen2thomas/gobot that referenced this pull request Jul 6, 2023
@dlstjq7685 @gen2thomas
all: substitute deprecated ioutil methods (hybridgroup#923)
1175db3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gen2thomas gen2thomas gen2thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlstjq7685 @gen2thomas