Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ble: add support for functional options, add tests #1059

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Feb 10, 2024

Solved issues and/or description of the change

One step closer to fix #1004 by:

  • adding some tests
  • align code (return errors, not log inside)
  • introduce functional options

Manual test

none

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test_race)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas marked this pull request as ready for review February 10, 2024 17:01
@gen2thomas gen2thomas merged commit d96aa52 into hybridgroup:dev Feb 10, 2024
2 checks passed
@gen2thomas gen2thomas deleted the feature/ble_test_coverage branch February 10, 2024 17:02
szampardi pushed a commit to szampardi/gobot that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant