Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(all): substitude assert.Error by assert.ErrorContains #1014

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Oct 25, 2023

Solved issues and/or description of the change

fix accidentally used assert.Error() (checks only for existing error, the text is used in case of fail) instead of assert.ErrorContains() (the text needs to be contained in the error)

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code (no productive code is changed)

@gen2thomas gen2thomas marked this pull request as ready for review October 25, 2023 18:21
@gen2thomas gen2thomas merged commit f9950e2 into hybridgroup:dev Oct 25, 2023
2 checks passed
@gen2thomas gen2thomas deleted the tests/fix_assert_error branch October 25, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant