Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 8 compatibility #10

Closed
joevaugh4n opened this issue Feb 21, 2024 · 6 comments
Closed

Storybook 8 compatibility #10

joevaugh4n opened this issue Feb 21, 2024 · 6 comments

Comments

@joevaugh4n
Copy link

Hey @hwookim ! I’m reaching out from the core SB team :)

Storybook 8 (our next major release) is coming soon, and it introduces some breaking changes that your addon might need to account for.

We’ve listed all the key changes in a new Storybook 8 migration guide, and we’d encourage you to check it out and see if your addon is impacted.

We also have an addons channel in our Discord community, which we’d like to use to better communicate with addon authors in the future. If you’re not part of the server, consider joining here and message me (@joevaugh4n) so that I can give you the addon creator role! If you’re already in the server, please just ping me and I’ll respond to you there.

Thanks for being a part of our addon community!

Joe

@sandwichsudo
Copy link

sandwichsudo commented Mar 14, 2024

Hiya, I've just tried upgrading to Storybook 8 and have found my cookies are no longer set once I upgraded my Storybook to version 8 when using this add-on. I'll try and investigate a bit more what the breaking change might be and add notes here.

First off, this message comes out when I start my Storybook with version 8 installed:

WARN The following packages are incompatible with Storybook 8.0.0 as they depend on different major versions of Storybook packages:
WARN - [email protected]

@sandwichsudo
Copy link

sandwichsudo commented Mar 14, 2024

I had a go at upgrading:

  • "@storybook/blocks": "^7.0.0",
  • "@storybook/components": "^7.0.0",
  • "@storybook/manager-api": "^7.0.0",
  • "@storybook/preview-api": "^7.0.0",
  • "@storybook/types": "^7.0.0",
  • "@storybook/blocks": "^8.0.0",
  • "@storybook/components": "^8.0.0",
  • "@storybook/manager-api": "^8.0.0",
  • "@storybook/preview-api": "^8.0.0",
  • "@storybook/types": "^8.0.0",

and then the demo Storybook up to v8.0 and seemed to work well

Screenshot 2024-03-14 at 17 05 29

Happy to push a PR if that's any help

@paul-asvb
Copy link
Contributor

i threw this together. #11

@hwookim
Copy link
Owner

hwookim commented May 16, 2024

I apologize for the delay in handling this issue.
I'll do my best to get it taken care of this week.

@fernandopasik
Copy link

Thank you for the update! Is there anything in particular why the alpha release for 4.0 and not a full one?

@hwookim
Copy link
Owner

hwookim commented Aug 8, 2024

@fernandopasik
There are a few issues we haven't resolved yet. #12 T.T
There is an issue with the parameter not being called properly on initial load and therefore not being properly exposed in the toolpane, which i'm still trying to resolve.

I'll try to resolve them as soon as possible!

@hwookim hwookim closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants