-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sets failing to save correctly when creating #72
Comments
Could you elaborate on this? Are you saying it will not save if the time spent on the creation/editing page is too long?
Does this occur after clicking create/save?
Are you saying that all progress was lost before clicking create/save? If so, this is expected. Save must be clicked, otherwise the data will not be saved. |
The save function is working. Sorry for my English, I think my english is confusing. |
Alright - to check, the issue occurs when the page is reloaded too quickly after creating a set, e.g. without giving it a few seconds? This is an issue that has been observed before, but unable to be replicated. No problem about the English. I've got friends too who are learning. |
actually it's like 5 seconds at least? it's really not a real quick. |
No worries. Let me know whether it is occurring when creating new sets and updating existing ones. i.e. does the issue occur when you update a set that already exists using the save "button," and also when creating new ones using the "create" button? |
How many cards did you have present in the set when you tried creating it, did any of them have pictures or text formatting? |
at least 10, just a plain text. |
I experience it again. So what I did now was create new set, error page didn't show this time. Will you change the creation of set? |
Progress saving is a real pain. |
Will definitely be looking into this issue later this week. If you want to try a quick fix, log out and log back in. Expired cookies can sometimes play havoc with authentication when creating sets. For right now until this issue is fixed, don't add a bunch of cards all at once when creating sets. Add small amounts at a time after initially creating incase the issue occurs. |
I already did that. Definitely, 1 at a time. |
I'll take a look into this since this seems to be pretty major. If you found any patterns of behaviors that may cause the issue, feel free to list them. |
I had written out about 50 cards and then pressed save, and it all disappeared. Likely due to me navigating away before the request was done. Very unfortunate. |
Did you navigate away while the request was still in progress - i.e. it hadn't redirected you to where the new set's page should be? Were you uploading many images while creating the cards? Been trying to wrestle this issue for weeks. |
@Green-Robot-Dev-Studios @ffsb07 A temporary fix for this issue has been applied in the latest release. |
Thank you very much! This is shaping up to be a great tool! 🚀 |
@hwgilbert16 A spinner and disabled Save button until the save request returns 200 should solve the issue. The same issue also happens if you haven't been refreshing the page for some time. In that case, what I do is I open another tab to keep my session refreshed, then click save on the flashcard page with that new session that I got from other page. This failed session operation will also be overlooked if you just look at the UI (save button). Oh by the way, thank you so much for the tool :) |
You're right. The issue was that the logic that refreshes the authentication tokens was being superseded by the individual authentication checks for privileged routes. @Green-Robot-Dev-Studios @ffsb07 @OrkunDzgn I pushed a permanent fix for this. If you're using the public version at https://scholarsome.com - the bug is fixed. If you're using a selfhosted local version, then this fix will be in the next update. |
Progress are not saved even save button was clicked when worked for too long.
Progress saved are deleted if you go back and forth from home to your set
Reloading page will delete all the progress >> it seems like it's having problem fetching data after paged refreshed.
The text was updated successfully, but these errors were encountered: