Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust-gmp to 0.3 to fix build on nightly rustc #2

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Bump rust-gmp to 0.3 to fix build on nightly rustc #2

merged 1 commit into from
Jun 6, 2017

Conversation

petrochenkov
Copy link
Contributor

Hi.
rust-lang/rust#42125 is going to turn some old compatibility "private-in-public" warnings in rustc into hard errors.
crates.io testing discovered that this crate uses an old version of rust-gmp affected by one of those errors.
This PR updates rust-gmp to 0.3, which is the minimal version building successfully with rust-lang/rust#42125

@hwchen
Copy link
Owner

hwchen commented Jun 1, 2017

Thanks! Will merge shortly.

@hwchen hwchen merged commit 7f42dda into hwchen:master Jun 6, 2017
@petrochenkov
Copy link
Contributor Author

@hwchen
Could you also publish the updated version to crates.io as secret-service-0.3.2?

@hwchen
Copy link
Owner

hwchen commented Jun 6, 2017 via email

@hwchen
Copy link
Owner

hwchen commented Jun 6, 2017

published! as 0.4.0, because of a more major change in #1

@petrochenkov
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants