Make pyhcl optional again
#1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See hvac#1038 (comment) This makes the `pyhcl` dependency installable via `pip install hvac[parser]` again like the README suggests. The `pyhcl` dependency is also specified as a dev dependency so that it is always installed during testing.
Codecov Report
@@ Coverage Diff @@
## main #1060 +/- ##
=======================================
Coverage 85.02% 85.02%
=======================================
Files 65 65
Lines 3139 3139
=======================================
Hits 2669 2669
Misses 470 470 |
briantist
added
dependencies
briantist
approved these changes
Sep 16, 2023
haha please do not apologize for that, love to see it, I would usually have tried to look at them sooner, but it's been one of those weeks... |
briantist
added a commit
to briantist/hvac
that referenced
this pull request
Sep 16, 2023
briantist
added a commit
that referenced
this pull request
Sep 20, 2023
* bump pytest version * reorder * update lockfile for pyhcl re: #1060
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1038
See comment #1038 (comment) .
This makes the
pyhcldependency installable viapip install hvac[parser]again like the README suggests.The
pyhcldependency is also specified as a dev dependency so that it is always installed during testing.Breaking change
hvacversion1.0.0, you had to installhvac[parser]forpyhclto be installed withhvachvac>=1.0.0,<2,pyhclwas always installed withhvachvac>=2.0.0this package is once again optional and can be installed withhvac[parser]