Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandbox.create() #10

Open
travi opened this issue Apr 30, 2018 · 3 comments
Open

sandbox.create() #10

travi opened this issue Apr 30, 2018 · 3 comments

Comments

@travi
Copy link

travi commented Apr 30, 2018

a new deprecation was published today, which results in the following message:

`sandbox.create()` is deprecated. Use default sandbox at `sinon.sandbox` or create new sandboxes with `sinon.createSandbox()`

we use the sandbox a ton throughout our projects, so simplifying this update would be huge for us. would it be reasonable to provide a codemod for this one?

@hurrymaplelad
Copy link
Owner

Sounds reasonable to me. PR welcome!

@travi
Copy link
Author

travi commented May 3, 2018

thanks for being open to it. we realized that sinon.createSandbox(), which was easy enough to update with find/replace. at first glance, we thought that moving to sinon.sandbox was the only option, which would have need a bigger change so we thought the codemod would be worthwhile.

i think we are actually past our need for this, so i'd be ok with closing this one. i'll let you decide if it's worth keeping open in case others would rather have a codemod to migrate to sinon.sandbox instead.

@vsubbotskyy
Copy link

#11
here's a start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants