rework misspelled spans to only the word. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinistersnare
changed the title
|
|
||
| if let Some(amt) = whole.find_str(w.as_slice()) { | ||
| pos.span.lo = pos.span.lo + BytePos(amt as u32); | ||
| pos.span.hi = pos.span.lo + BytePos(w.len() as u32); |
There was a problem hiding this comment.
I think this needs to be amt + w.len().
There was a problem hiding this comment.
nope, the hi of the span is the lo + the length, if you added amt, youd go way out there, and the span would be of large length
unless my math is really bad?
There was a problem hiding this comment.
Oh, sorry, you are correct: I didn't take into account the modification on the previous line.
sinistersnare
force-pushed
the
extract-spans
branch
from
4861101 to
f8e569b
Compare
sinistersnare
force-pushed
the
extract-spans
branch
from
4f30f78 to
ca044f6
Compare
sinistersnare
changed the title
|
Hey @sinistersnare I completely forgot about this. I just updated the main code to master, so I'm happy to take this and rebase it, but I'm also happy for you to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there is a bug
with /** style doc comments, but /// doc comments work perfectly.that sometimes moves the span.Just wanted to put this up to motivate me to try and do more later, because I am good for the night now :)
closes #7