Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the specification of the word list in a crate attribute #10

Open
chris-morgan opened this issue Jul 5, 2014 · 7 comments
Open

Comments

@chris-morgan
Copy link

It might be nice to be able to define an attribute like #![spellck_lint_dict = "/path/to/words"] on the crate, instead of depending on the environment variable SPELLCK_LINT_DICT.

@huonw
Copy link
Owner

huonw commented Jul 5, 2014

Note that this would essentially only be usable as a replacement for #8 (if there's too many words), with a relative path to a file that is distributed with library.

@chris-morgan
Copy link
Author

@huonw Well, this was intended as “the language word list”, whereas #8 was more “the domain word list”. I suppose you can have multiple copies of this attribute, though, so it might serve the purpose effectively, except for the question of whether this removes any dictionaries that might otherwise be loaded (does it override or add?).

@huonw
Copy link
Owner

huonw commented Jul 5, 2014

It still needs to be distributed with the library: essentially any use of this plugin requires dictionaries to be distributed with the library for full flexibility, e.g. even if /usr/share/dict/words exists, its contents differs.

@huonw
Copy link
Owner

huonw commented Jul 5, 2014

#11 will help address my last point.

@sinistersnare
Copy link
Contributor

Is this still wanted now that #8 is closed?

@huonw
Copy link
Owner

huonw commented Nov 20, 2014

Yes, it's not sensible to force the entire dictionary to be written inline at the top of a source file. 😄

@sinistersnare
Copy link
Contributor

Ok, ill think about this then :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants