Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close on outside click doesn't work for nested drawers #74

Open
aram-p opened this issue Apr 15, 2024 · 2 comments · May be fixed by #102
Open

close on outside click doesn't work for nested drawers #74

aram-p opened this issue Apr 15, 2024 · 2 comments · May be fixed by #102

Comments

@aram-p
Copy link

aram-p commented Apr 15, 2024

Describe the bug

if there is a drawer in another drawer clicking outside for either Drawer.Content won't do anything

Reproduction

https://stackblitz.com/edit/vaul-svelte-nested-drawers

open stackblitz, open drawer and click outside

Logs

No response

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.3 - /usr/local/bin/pnpm
  npmPackages:
    @sveltejs/kit: ^2.0.0 => 2.0.6 
    svelte: ^4.2.7 => 4.2.8 
    typescript: ^5.0.0 => 5.3.3 
    vaul-svelte: latest => 0.3.0


### Severity

annoyance
@aram-p aram-p closed this as completed Apr 16, 2024
@aram-p aram-p reopened this Apr 16, 2024
@thedivtagguy
Copy link

Did you ever find a workaround for this? Same problem here.

@aram-p
Copy link
Author

aram-p commented Nov 3, 2024

No.

@thedivtagguy thedivtagguy linked a pull request Nov 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes closeOnOutsideClick for nested drawers thedivtagguy/vaul-svelte
2 participants
@thedivtagguy @aram-p