Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "OpenProject" as a new Custom Service. #680

Merged
merged 3 commits into from
May 2, 2023
Merged

Adding "OpenProject" as a new Custom Service. #680

merged 3 commits into from
May 2, 2023

Conversation

Bernhard-Krop
Copy link
Contributor

Hi there!

As the title says, I've added "OpenProject" as a new custom service. I tested it well and everything works fine. The details are described in the Git commit message and should be reviewed.

Kind regards,

Bernhard

Bernhard-Krop and others added 2 commits April 5, 2023 15:10
@Bernhard-Krop
* Added "OpenProject" as a custom service.
94dcbf3 
* Added new const function "findProjectByLabel".
* When trying to get the correct MOCO project, findProjectByLabel() is now used to identify the correct (internal) project, too.
* Increased width of label boxes in browser extension settings for service host overrides.
@Bernhard-Krop
Merge branch 'hundertzehn:master' into master
dda18c6
@Bernhard-Krop Bernhard-Krop mentioned this pull request Apr 26, 2023
Closed
manubo
manubo reviewed Apr 27, 2023
View reviewed changes
src/js/components/Options.js Show resolved Hide resolved
src/js/remoteServices.js Show resolved Hide resolved
src/js/remoteServices.js Outdated Show resolved Hide resolved
src/js/remoteServices.js Outdated Show resolved Hide resolved
@manubo
Copy link
Contributor

manubo commented Apr 27, 2023

Thanks for your PR @Bernhard-Krop.
Could you please check my comments?

@Bernhard-Krop
Copy link
Contributor Author

I've answered to each of your comments, @manubo. I left one question and am working on the others.

@Bernhard-Krop
* Introduced new property "projectLabel" to remote service entries.
6460244 
* * Remote service "openproject" is now using "projectLabel" instead of "projectId".
* Added missing default host URL to remote service "openproject".
@Bernhard-Krop
Copy link
Contributor Author

@manubo , I've implemented the new property proejctLabel and added remote service host for "openproject". I would like you to review my changes and mark your comments as resolved, if they are resolved. As soon as you answered my question regarding the service name width, I'll apply it in a new commit.

@manubo
Copy link
Contributor

manubo commented Apr 27, 2023

Thanks @Bernhard-Krop. I have answered regarding the width. We can keep it simple and just increase it to 80px. I have attached screenshots here and it looks fine with 80px, do you agree?

@Bernhard-Krop
Copy link
Contributor Author

@manubo , it seems like there is a bug in one of the two browsers (see my message in your comment). This should be investigated, but I won't have much time starting tomorrow for 1-2 weeks. Either we wait until I have time to fix it, or we keep it 100px now and fix it later.

@manubo manubo merged commit f8e7fc9 into everii-Group:master May 2, 2023
@manubo
Copy link
Contributor

manubo commented May 2, 2023 •
edited
Loading

@Bernhard-Krop This PR has been released in Version 2.3.0. It's already available for Firefox, Chrome will follow.
Thanks for your contribution!

@Bernhard-Krop Bernhard-Krop mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manubo manubo manubo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bernhard-Krop @manubo