Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Provider for New Search #382

Closed
luke- opened this issue Mar 24, 2024 · 8 comments
Closed

Create Provider for New Search #382

luke- opened this issue Mar 24, 2024 · 8 comments
Assignees

Comments

@luke-
Copy link
Contributor

luke- commented Mar 24, 2024

No description provided.

@yurabakhtin
Copy link
Contributor

@luke- I have started it in the PR #386:

mail-meta-search

Should we implement also new controller and search drivers with indexing as we have for Content searching?

mail-search

@luke-
Copy link
Contributor Author

luke- commented Apr 15, 2024

@yurabakhtin Cool. Can't we just use this existing view?

image

@yurabakhtin
Copy link
Contributor

@luke-

Can't we just use this existing view?

Ok, I will try to do it.
I just thought we should display in the Meta Search panel MessageEntry records, but the Messaging Filter returns Message records, so I will display Message records in the in the Meta Search panel as well, is it ok?

@yurabakhtin
Copy link
Contributor

@luke- Also currently we load only last 50 message entries on the right part, so if a message entry is a very old then user should scroll up to find it where it was written, i.e. current message searching has no a direct link to a Message Entry. If it is ok then we can use the current searching, otherwise we should implement another with direct linking to a Message Entry. What do you think?

@yurabakhtin
Copy link
Contributor

@luke- Please review how it looks after commit 143ad91 where I have applied the same searching what is used for the existing filter:

mail-search

@luke-
Copy link
Contributor Author

luke- commented Apr 19, 2024

@luke- Also currently we load only last 50 message entries on the right part, so if a message entry is a very old then user should scroll up to find it where it was written, i.e. current message searching has no a direct link to a Message Entry. If it is ok then we can use the current searching, otherwise we should implement another with direct linking to a Message Entry. What do you think?

Thats fine. But thanks for the info.

@luke-
Copy link
Contributor Author

luke- commented Apr 19, 2024

@luke-

Can't we just use this existing view?

Ok, I will try to do it. I just thought we should display in the Meta Search panel MessageEntry records, but the Messaging Filter returns Message records, so I will display Message records in the in the Meta Search panel as well, is it ok?

@yurabakhtin

I would prefer to continue to display "Message" records here and not the search results in the MessageEntries.
But that's the current implementation, isn't it?

I think the current PR is ok in terms of functionality. Is it something to check/discuss?

@yurabakhtin
Copy link
Contributor

@luke-

I would prefer to continue to display "Message" records here and not the search results in the MessageEntries.
But that's the current implementation, isn't it?

Yes, it works this way, search items are "Message" records.

I think the current PR is ok in terms of functionality. Is it something to check/discuss?

I confirm, you can merge it.

@luke- luke- closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants