Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display "person1 has left the conversation" in message preview panel #313

Closed
Eladnarlea opened this issue Mar 14, 2023 · 3 comments · Fixed by #315
Closed

display "person1 has left the conversation" in message preview panel #313

Eladnarlea opened this issue Mar 14, 2023 · 3 comments · Fixed by #315
Assignees
@yurabakhtin
Labels
bug
Milestone
3.0

Comments

@Eladnarlea
Copy link

I realised that it is quite confusing that you get notified that there is a new message in the conversation but actually it is about one person leaving the chat. Hence I think it is important to display "person X has left the conversation" in the message preview on the left side. Please note that it should only be shown in the preview when someone has left/entered.

Screen Shot 2023-03-14 at 11 33 53 AM
@Eladnarlea Eladnarlea added the bug label Mar 14, 2023
@Eladnarlea Eladnarlea added this to the 3.0 milestone Mar 14, 2023
@yurabakhtin yurabakhtin mentioned this issue Mar 20, 2023
Merged
@yurabakhtin yurabakhtin linked a pull request Mar 20, 2023 that will close this issue
Display state(joined/left) messages in inbox #315
Merged
@yurabakhtin
Copy link
Contributor

@Eladnarlea @luke- PR #315:

state_message_inbox

@luke-
Copy link
Contributor

luke- commented Mar 21, 2023

@Eladnarlea Can you please review? Should be updated on your test installation.

@Eladnarlea
Copy link
Author

perfect, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurabakhtin yurabakhtin

Labels
bug
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Display state(joined/left) messages in inbox humhub/mail
3 participants
@luke- @yurabakhtin @Eladnarlea