Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/gjk_convergence_criterion: Add check on GJK::Status #315

Merged

Conversation

wxmerkt
Copy link
Contributor

@wxmerkt wxmerkt commented Jun 30, 2022

We are setting but never verifying the status in the test

Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot @wxmerkt for your contribution.

@jcarpent jcarpent merged commit 5b5cd39 into coal-library:devel Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants