Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit config #18

Closed
jamesquilty opened this issue Feb 14, 2024 · 1 comment · Fixed by #19
Closed

Update pre-commit config #18

jamesquilty opened this issue Feb 14, 2024 · 1 comment · Fixed by #19

Comments

@jamesquilty
Copy link
Contributor

After cloning this repository and attempting to commit locally, pre-commit fails at the Initializing environment ... stage. There are at least two problems with .pre-commit-config.yaml:

  1. fails on flake8 installation with a request for username and password to login to GitLab because the entry points at https://gitlab.com/pycqa/flake8 which no longer exists;
  2. fails to install iSort with error "RuntimeError: The Poetry configuration is invalid"

At this point I gave up and ran pre-commit autoupdate which then also failed to complete environment initialisation because:

  1. flake8 0.7.0 (latest) is outside the flake8-comprehensions 3.3.1 version requirements flake8!=3.2.0, <4 and >=3.0 (flake8-comprehensions is specified in the flake8 additional_dependencies section).

Fixing (3) by specifying the latest flake8 3.x version, version 3.9.2, allows pre-commit environment initialisation to complete.

Copy link

welcome bot commented Feb 14, 2024

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@jamesquilty jamesquilty changed the title pre-commit config requires updating Update pre-commit config Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant