Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation treats multiple categories too leniently #91

Open
danielhers opened this issue May 15, 2020 · 4 comments
Open

Evaluation treats multiple categories too leniently #91

danielhers opened this issue May 15, 2020 · 4 comments

Comments

@danielhers
Copy link
Member

Evaluation is by spans, and if there is a non-empty intersection of the categories, then the span is considered correct. This is a problem because parsers can just predict many unary edges or multi-category edges and not be penalized for it: https://github.com/danielhers/ucca/blob/master/ucca/evaluation.py#L102
@omriabnd @nschneid

@nschneid
Copy link

One subtlety is that, because F nodes are moved under the root, we are left with superfluous C nodes:

[F The] [H [P [C service] ] ... [D poor] [U ...] ] [F is]

Should they be removed? I.e.:

[F The] [H [P service ] ... [D poor] [U ...] ] [F is]

Scoring P and C separately here (in an edge-based evaluation) would seem inconsistent with the notion of ignoring where F attaches.

@danielhers
Copy link
Member Author

Yes, I think normalization (including C-flattening) should occur again after moving Fs.

@nschneid
Copy link

Should moving all Fs be part of normalization? For structures like [S [F the] [C xyz]] it would make it more transparent that xyz is evoking a scene.

@nschneid
Copy link

Also: the confusion matrix code should match the F-score computation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants