Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization of remote Coordinated Main Relations #90

Open
danielhers opened this issue May 11, 2020 · 0 comments
Open

Normalization of remote Coordinated Main Relations #90

danielhers opened this issue May 11, 2020 · 0 comments

Comments

@danielhers
Copy link
Member

The conversion from json checks if the edge has a CMR category and then sets a CMR attrib: https://github.com/danielhers/ucca/blob/master/ucca/convert.py#L968
Then the normalization finds this attrib, splits the relation and destroys the node: https://github.com/danielhers/ucca/blob/master/ucca/normalization.py#L260

A remote CMR is expanded such that the second scene points only to the first conjunct.
This way the last, remote-only scene is dropped, and the result is not logically equivalent.
It will have a remote which is a CMR that is half-expanded, and includes only the first conjunct (what was originally the first Center).
Otherwise, if we expanded the full Cartesian product, we would get a scene containing only remotes, which is possible - we should mark it as an implicit scene, but we have never had something like that yet.
CMR is not a category we're currently supporting in the final XMLs, and it would be weird to include it only in those cases.

Perhaps CMRs should not be split, but rather be treated just like regular P/S (at least in these cases). If we turn it into LF we could split them, but as it is, we should not split CMRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant