Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clBlas error #127

Open
skn123 opened this issue Jul 31, 2017 · 5 comments
Open

clBlas error #127

skn123 opened this issue Jul 31, 2017 · 5 comments

Comments

@skn123
Copy link

skn123 commented Jul 31, 2017

Looks like you will have to change the clBlas files in your recursive pull.
/home/naths/srcs/DeepCL/clMathLibraries/clBLAS/src/library/blas/trtri/diag_dtrtri_lower_128_16.cpp:65:2: error:
embedding a #pragma directive within macro arguments is not supported
#pragma unroll\n
^
/home/naths/srcs/DeepCL/clMathLibraries/clBLAS/src/library/blas/trtri/diag_dtrtri_lower_128_16.cpp:141:2: error:
embedding a #pragma directive within macro arguments is not supported
#pragma unroll\n
^
/home/naths/srcs/DeepCL/clMathLibraries/clBLAS/src/library/blas/trtri/diag_dtrtri_lower_128_16.cpp:166:2: error:
embedding a #pragma directive within macro arguments is not supported
#pragma unroll\n

The error has been fixed here:
http://lists.alioth.debian.org/pipermail/debian-science-commits/2016-January/056094.html

@hughperkins
Copy link
Owner

Upgrading clBLAS is a ton of work. It might be easier just to backport the fix, into the current clBLAS fork, ie to https://github.com/hughperkins/clBLAS/tree/2.11-bugfixes (I think).

Thoughts?

@skn123
Copy link
Author

skn123 commented Jul 31, 2017

Your call :) I have no problem either way. Its just that I have clBlas as en external Library also and would ideally like to have clBlas as an external build rather than part of a superbuild. In that way, both conditions are satisfied. Thoughts?

@hughperkins
Copy link
Owner

Its just that I have clBlas as en external Library also and would ideally like to have clBlas as an external build rather than part of a superbuild

Ah. Personally, I found there were a few bugs to work around each time I upgraded... Since I was using an NVIDIA GPU at the time, those were both blocker bugs for me, and not really supported by AMD :-) . I suppose I was probably the only NVIDIA user of clBLAS :-P

If you want to dabble in upgrading to the latest version of clBLAS please go ahead. It would be most convenient if it was tested on all of ubuntu, Mac and windows, but no reason why you couldnt create a branch on your favored OS, and someone else could come along and fix the branch for one or more of the other OSes.

@skn123
Copy link
Author

skn123 commented Sep 5, 2017

Looks like this was fixed here
clMathLibraries/clBLAS@9d4c312
But I think the pull does not reflect it in DeepCL

@hughperkins
Copy link
Owner

Thoughts on backporting this into the version of clBLAS used by DeepCL?

Alternatively, thoughts on upgrading DeepCL to latest version of clBLAS? (we could do this in a branch perhaps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants