From 221f587f6c5aff30d5fb9bbf60a433b820eeccc7 Mon Sep 17 00:00:00 2001 From: yonigozlan Date: Mon, 6 Oct 2025 15:59:34 +0000 Subject: [PATCH 1/2] set common_kwargs defaults before updating with kwargs --- src/transformers/processing_utils.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/transformers/processing_utils.py b/src/transformers/processing_utils.py index e7786d1ba61d..6b8ff98e0e3c 100644 --- a/src/transformers/processing_utils.py +++ b/src/transformers/processing_utils.py @@ -1305,6 +1305,13 @@ class MyProcessingKwargs(ProcessingKwargs, CommonKwargs, TextKwargs, ImagesKwarg # pass defaults to output dictionary output_kwargs.update(default_kwargs) + # For `common_kwargs` just update all modality-specific kwargs with same key/values + common_kwargs = kwargs.get("common_kwargs", {}) + common_kwargs.update(ModelProcessorKwargs._defaults.get("common_kwargs", {})) + if common_kwargs: + for kwarg in output_kwargs.values(): + kwarg.update(common_kwargs) + # update modality kwargs with passed kwargs non_modality_kwargs = set(kwargs) - set(output_kwargs) for modality, output_kwarg in output_kwargs.items(): @@ -1354,13 +1361,6 @@ class MyProcessingKwargs(ProcessingKwargs, CommonKwargs, TextKwargs, ImagesKwarg f"Keyword argument `{key}` is not a valid argument for this processor and will be ignored." ) - # For `common_kwargs` just update all modality-specific kwargs with same key/values - common_kwargs = kwargs.get("common_kwargs", {}) - common_kwargs.update(ModelProcessorKwargs._defaults.get("common_kwargs", {})) - if common_kwargs: - for kwarg in output_kwargs.values(): - kwarg.update(common_kwargs) - return output_kwargs @classmethod From c2ace8b30bb15ae66e1ee77a4ae7dc66b6a027cb Mon Sep 17 00:00:00 2001 From: yonigozlan Date: Wed, 8 Oct 2025 02:59:54 +0000 Subject: [PATCH 2/2] change order to override defaults common_kwargs --- src/transformers/processing_utils.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/transformers/processing_utils.py b/src/transformers/processing_utils.py index 6b8ff98e0e3c..8040fbf9d97b 100644 --- a/src/transformers/processing_utils.py +++ b/src/transformers/processing_utils.py @@ -1306,8 +1306,8 @@ class MyProcessingKwargs(ProcessingKwargs, CommonKwargs, TextKwargs, ImagesKwarg output_kwargs.update(default_kwargs) # For `common_kwargs` just update all modality-specific kwargs with same key/values - common_kwargs = kwargs.get("common_kwargs", {}) - common_kwargs.update(ModelProcessorKwargs._defaults.get("common_kwargs", {})) + common_kwargs = ModelProcessorKwargs._defaults.get("common_kwargs", {}) + common_kwargs.update(kwargs.get("common_kwargs", {})) if common_kwargs: for kwarg in output_kwargs.values(): kwarg.update(common_kwargs)