Skip to content

corrected the code comment for the output of find_pruneable_heads_and_indices #22557

Merged
sgugger merged 2 commits into
huggingface:mainfrom
SunHaozhe:main
Apr 4, 2023
Merged

corrected the code comment for the output of find_pruneable_heads_and_indices #22557
sgugger merged 2 commits into
huggingface:mainfrom
SunHaozhe:main

Conversation

@SunHaozhe

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR improves the doc (code comment), because the code comment of find_pruneable_heads_and_indices was not correct.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@anmolsjoshi @sgugger

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Apr 4, 2023

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification! Cna you just run male style on your branch so we can merge this?

@sgugger sgugger merged commit fc5b741 into huggingface:main Apr 4, 2023
raghavanone pushed a commit to raghavanone/transformers that referenced this pull request Apr 5, 2023
…_indices (huggingface#22557)

* corrected/clarified the code comment of find_pruneable_heads_and_indices

* have run make style
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
…_indices (huggingface#22557)

* corrected/clarified the code comment of find_pruneable_heads_and_indices

* have run make style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants