Skip to content

Generate: Enable easier TextStreamer customization #22516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gante merged 2 commits into from
Apr 3, 2023
+6 −2
Merged

Generate: Enable easier TextStreamer customization #22516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
730503a
Add callback function easily customizable by TextStreamer subclasses
vblagoje Apr 2, 2023
9c275b7
PR feedback: rename method to on_finalized_text
vblagoje Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/transformers/generation/streamers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def put(self, value):
printable_text = text[self.print_len : text.rfind(" ") + 1]
self.print_len += len(printable_text)

print(printable_text, flush=True, end="")
self.on_finalized_text(printable_text)

def end(self):
"""Flushes any remaining cache and prints a newline to stdout."""
Expand All @@ -102,7 +102,11 @@ def end(self):
printable_text = ""

# Print a newline (and the remaining text, if any)
print(printable_text, flush=True)
self.on_finalized_text(printable_text, stream_end=True)

def on_finalized_text(self, token: str, stream_end: bool = False):
"""Prints the new text to stdout."""
print(token, flush=True, end="" if not stream_end else None)


class TextIteratorStreamer(BaseStreamer):
Expand Down