Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreTrainedModel.from_pretrained(...) doesn't pass cache_dir to PretrainedConfig.from_pretrained(...) #863

Closed
mbugert opened this issue Jul 22, 2019 · 1 comment

Comments

@mbugert
Copy link

mbugert commented Jul 22, 2019

The cache_dir key-value parameter does not work as intended in PreTrainedModel.from_pretrained(...). It is popped from the kwargs, then PretrainedConfig.from_pretrained(...) is called which expects this parameter in the kwargs, but it's obviously not there anymore. A default location is used as a fallback, but this leads to strange behaviour if this default location doesn't exist or isn't writable (as it was in my case).

@thomwolf
Copy link
Member

Fix with #866

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants