Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useful Sensors Moonshine Transcription Model #34474

Closed
2 tasks done
njeffrie opened this issue Oct 28, 2024 · 3 comments
Closed
2 tasks done

Useful Sensors Moonshine Transcription Model #34474

njeffrie opened this issue Oct 28, 2024 · 3 comments

Comments

@njeffrie
Copy link

Model description

Model description can be found in the Moonshine Whitepaper.

I will be porting our existing torch model to Transformers.

Open source status

  • The model implementation is available
  • The model weights are available

Provide useful links for the implementation

Implementation Special credit to @keveman for training and @evmaki for data collection and preprocessing.
Model weights

@Rocketknight1
Copy link
Member

Hi @njeffrie, generally our recommendation is to port models as "custom code" models first. In these models, the code is included in the model repo itself, rather than in the core transformers library. You can write custom code models yourself without needing to open a PR to transformers, and users can still load them with AutoModel.from_pretrained(). Take a look at the docs here for more information.

@njeffrie
Copy link
Author

Excellent, thanks for the pointer! I'll definitely do this first, then we will consider creating a PR to add the model to transformers in the slightly longer term.

For now I'll keep this open for reference and for the future PR, unless you'd prefer I close then re-open the issue alongside a future PR to transformers.

@Rocketknight1
Copy link
Member

I think you can close this for now, and reopen it later if you want to push for a full library PR!

@njeffrie njeffrie closed this as completed Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants