Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghost development dependency terser-webpack-plugin #1085

Open
5 tasks
ae9is opened this issue Dec 10, 2024 · 0 comments · May be fixed by #1086
Open
5 tasks

Ghost development dependency terser-webpack-plugin #1085

ae9is opened this issue Dec 10, 2024 · 0 comments · May be fixed by #1086
Labels
bug Something isn't working

Comments

@ae9is
Copy link

ae9is commented Dec 10, 2024

System Info

n/a

Environment/Platform

  • Website/web-app
  • Browser extension
  • Server-side (e.g., Node.js, Deno, Bun)
  • Desktop app (e.g., Electron)
  • Other (e.g., VSCode extension)

Description

terser-webpack-plugin is imported but not declared as a development dependency in package.json.

https://github.com/huggingface/transformers.js/blob/14bf689c983c68c7e870b970e1bcce79c791c3c9/webpack.config.js#L1C1-L1C50

Reproduction

npm hides issues with ghost dependencies, use another package manager like pnpm to easily verify.
@ae9is ae9is added the bug Something isn't working label Dec 10, 2024
@ae9is ae9is linked a pull request Dec 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ghost development dependency terser-webpack-plugin ae9is/transformers.js
1 participant
@ae9is