Skip to content

Fix training args transformers compatibility #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echarlaix merged 2 commits into from
Mar 25, 2024
Merged

Fix training args transformers compatibility #1770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
731f84f
Fix training args compatibility with transformers v4.38.0 or lower
echarlaix Mar 25, 2024
b226c09
format
echarlaix Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions optimum/onnxruntime/training_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,13 @@
)
from transformers.utils.generic import strtobool

from ..utils.import_utils import check_if_transformers_greater


if is_torch_available():
import torch

if is_accelerate_available():
if is_accelerate_available() and check_if_transformers_greater("4.38.0"):
from transformers.trainer_pt_utils import AcceleratorConfig


Expand Down Expand Up @@ -449,7 +451,7 @@ def __post_init__(self):
os.environ[f"{prefix}SYNC_MODULE_STATES"] = self.fsdp_config.get("sync_module_states", "true")
os.environ[f"{prefix}USE_ORIG_PARAMS"] = self.fsdp_config.get("use_orig_params", "false")

if is_accelerate_available():
if is_accelerate_available() and check_if_transformers_greater("4.38.0"):
if not isinstance(self.accelerator_config, (AcceleratorConfig)):
if self.accelerator_config is None:
self.accelerator_config = AcceleratorConfig()
Expand Down