From af56d3cb4bdf583c7aad3fd8f8859bda649eda1c Mon Sep 17 00:00:00 2001 From: Philipp Schmid <32632186+philschmid@users.noreply.github.com> Date: Fri, 3 Nov 2023 14:23:02 +0100 Subject: [PATCH 1/6] Add revision to push_to_hub --- optimum/neuron/modeling_base.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/optimum/neuron/modeling_base.py b/optimum/neuron/modeling_base.py index 7e6e3da3f..ca70f3aeb 100644 --- a/optimum/neuron/modeling_base.py +++ b/optimum/neuron/modeling_base.py @@ -317,6 +317,7 @@ def push_to_hub( save_directory: str, repository_id: str, private: Optional[bool] = None, + revision: Optional[str] = "main", use_auth_token: Union[bool, str] = True, endpoint: Optional[str] = None, ) -> str: @@ -348,6 +349,7 @@ def push_to_hub( repo_id=repository_id, path_or_fileobj=os.path.join(os.getcwd(), local_file_path), path_in_repo=hub_file_path, + revision=revision ) def forward(self, *args, **kwargs): From 7880cf6c7b52abaf8438776f4d57815e4bbfdf92 Mon Sep 17 00:00:00 2001 From: philschmid Date: Fri, 3 Nov 2023 13:41:23 +0000 Subject: [PATCH 2/6] make style --- optimum/neuron/modeling_base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/optimum/neuron/modeling_base.py b/optimum/neuron/modeling_base.py index ca70f3aeb..110b0c17e 100644 --- a/optimum/neuron/modeling_base.py +++ b/optimum/neuron/modeling_base.py @@ -349,7 +349,7 @@ def push_to_hub( repo_id=repository_id, path_or_fileobj=os.path.join(os.getcwd(), local_file_path), path_in_repo=hub_file_path, - revision=revision + revision=revision, ) def forward(self, *args, **kwargs): From 4c935ca5bf092528cc5cea740a0d4b0755c40eca Mon Sep 17 00:00:00 2001 From: philschmid Date: Fri, 3 Nov 2023 13:49:21 +0000 Subject: [PATCH 3/6] remove fairscale --- optimum/neuron/trainers.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/optimum/neuron/trainers.py b/optimum/neuron/trainers.py index 2de816818..e70e0d1f9 100755 --- a/optimum/neuron/trainers.py +++ b/optimum/neuron/trainers.py @@ -28,7 +28,6 @@ from packaging import version from transformers import PreTrainedModel, Seq2SeqTrainer, Trainer, TrainingArguments from transformers.dependency_versions_check import dep_version_check -from transformers.integrations import is_fairscale_available from transformers.modeling_utils import unwrap_model from transformers.trainer import ( OPTIMIZER_NAME, @@ -80,9 +79,6 @@ else: IS_SAGEMAKER_MP_POST_1_10 = False -if is_fairscale_available(): - dep_version_check("fairscale") - logger = logging.get_logger("transformers.trainer") From 817d0f4fc91717785183e50e6f09a9e212171bf8 Mon Sep 17 00:00:00 2001 From: philschmid Date: Fri, 3 Nov 2023 13:53:19 +0000 Subject: [PATCH 4/6] style happy --- optimum/neuron/trainers.py | 1 - 1 file changed, 1 deletion(-) diff --git a/optimum/neuron/trainers.py b/optimum/neuron/trainers.py index e70e0d1f9..36af2efd1 100755 --- a/optimum/neuron/trainers.py +++ b/optimum/neuron/trainers.py @@ -27,7 +27,6 @@ import torch from packaging import version from transformers import PreTrainedModel, Seq2SeqTrainer, Trainer, TrainingArguments -from transformers.dependency_versions_check import dep_version_check from transformers.modeling_utils import unwrap_model from transformers.trainer import ( OPTIMIZER_NAME, From fe367010389eb1b998cba51bf5d5f1563c0e7673 Mon Sep 17 00:00:00 2001 From: Philipp Schmid <32632186+philschmid@users.noreply.github.com> Date: Fri, 3 Nov 2023 17:00:26 +0100 Subject: [PATCH 5/6] Update modeling_base.py --- optimum/neuron/modeling_base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/optimum/neuron/modeling_base.py b/optimum/neuron/modeling_base.py index 110b0c17e..be6a4950f 100644 --- a/optimum/neuron/modeling_base.py +++ b/optimum/neuron/modeling_base.py @@ -317,7 +317,7 @@ def push_to_hub( save_directory: str, repository_id: str, private: Optional[bool] = None, - revision: Optional[str] = "main", + revision: Optional[str] = None, use_auth_token: Union[bool, str] = True, endpoint: Optional[str] = None, ) -> str: From 0b5338ee413039344e6eb8c37ba79f512e558aff Mon Sep 17 00:00:00 2001 From: Philipp Schmid <32632186+philschmid@users.noreply.github.com> Date: Mon, 6 Nov 2023 17:18:30 +0100 Subject: [PATCH 6/6] Update modeling_decoder.py --- optimum/neuron/modeling_decoder.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/optimum/neuron/modeling_decoder.py b/optimum/neuron/modeling_decoder.py index 6f8f3dbbb..a05022aef 100644 --- a/optimum/neuron/modeling_decoder.py +++ b/optimum/neuron/modeling_decoder.py @@ -259,6 +259,7 @@ def push_to_hub( save_directory: str, repository_id: str, private: Optional[bool] = None, + revision: Optional[str] = None, use_auth_token: Union[bool, str] = True, endpoint: Optional[str] = None, ) -> str: @@ -290,4 +291,5 @@ def push_to_hub( repo_id=repository_id, path_or_fileobj=os.path.join(os.getcwd(), local_file_path), path_in_repo=hub_file_path, + revision=revision, )