Adding a flag whether to save checkpoint or not in run_lora_clm.py#736
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
@yeonsily Can you run |
Collaborator
Author
Strange.. I didn't see any style change from make style.. Let me check further. |
regisss
approved these changes
Feb 27, 2024
Collaborator
regisss
left a comment
regisss
left a comment
There was a problem hiding this comment.
LGTM
@yeonsily I've seen a few occurrences where the same version of ruff produces different results in two different environments. It's rare enough so that it's not really an issue but it may be the reason why you got a different output 🙁
jychen21
pushed a commit
to jychen21/optimum-habana
that referenced
this pull request
Feb 27, 2024
puneeshkhanna
pushed a commit
to puneeshkhanna/optimum-habana-fork
that referenced
this pull request
Mar 11, 2024
HolyFalafel
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Mar 11, 2024
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Oct 15, 2025
…gface#736) Co-authored-by: Grzegorz Pluto-Prondzinski <gplutopx@habana.ai>
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Nov 6, 2025
…gface#736) Co-authored-by: Grzegorz Pluto-Prondzinski <gplutopx@habana.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same change as PR #711 but for different script.
What does this PR do?
Fixes # (issue)
Before submitting