Fix error in PR#654#661
Merged
Merged
Conversation
1) fix for invalid input shape with DS 0.12.4 2) revert --skip_hash_with_views changes 3) add falcon to model_on_meta()
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
mandy-li
reviewed
Jan 24, 2024
Collaborator
mandy-li
left a comment
mandy-li
left a comment
There was a problem hiding this comment.
@schoi-habana , can you combine the two conditions to one so that only one else will be needed?
mandy-li
approved these changes
Jan 24, 2024
jychen21
pushed a commit
to jychen21/optimum-habana
that referenced
this pull request
Feb 27, 2024
* Falcon changes for 1.14.0 1) fix for invalid input shape with DS 0.12.4 2) revert --skip_hash_with_views changes 3) add falcon to model_on_meta() * address comments * README change * make PR#654 backward compatible for other models * address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensure backward compatibility for models other than Falcon
Before submitting