Skip to content

enable master_port selecting for DeepSpeed and MPI#641

Merged
regisss merged 3 commits into
huggingface:mainfrom
yangulei:master_port
Jan 17, 2024
Merged

enable master_port selecting for DeepSpeed and MPI#641
regisss merged 3 commits into
huggingface:mainfrom
yangulei:master_port

Conversation

@yangulei
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR adds a parameter to set master_port for DeepSpeed and MPI, which is motivated by running multiple DeepSpeed tasks simultaneously with each task using various parts of the HPUs.

@yangulei yangulei requested a review from regisss as a code owner January 17, 2024 02:43
@regisss
Copy link
Copy Markdown
Collaborator

regisss commented Jan 17, 2024

The code quality check failed, can you run the following from the root of the repo please?

pip install --upgrade ruff
make style

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@regisss regisss added the run-test Run CI for PRs from external contributors label Jan 17, 2024
Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@regisss regisss merged commit 8851ef6 into huggingface:main Jan 17, 2024
jychen21 pushed a commit to jychen21/optimum-habana that referenced this pull request Feb 27, 2024
gplutop7 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Oct 15, 2025
…) (huggingface#641)

Co-authored-by: Silvia Colabrese <silvia.colabrese@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-test Run CI for PRs from external contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants