Skip to content

Restructure example/trl/stack_llama_2 for generic DPO #635

Merged
regisss merged 7 commits into
mainfrom
dpo_restructure
Jan 16, 2024
Merged

Restructure example/trl/stack_llama_2 for generic DPO #635
regisss merged 7 commits into
mainfrom
dpo_restructure

Conversation

@libinta
Copy link
Copy Markdown
Collaborator

@libinta libinta commented Jan 11, 2024

Restructure example/trl/stack_llama_2 for generic DPO. Will add Anthropic dataset later

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@libinta libinta requested a review from regisss as a code owner January 11, 2024 08:24
@libinta libinta changed the title Restructure example/trl/stack_llama_2 for generic PPO Restructure example/trl/stack_llama_2 for generic DPO Jan 11, 2024
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You'll need to run make style too.

Comment thread examples/trl/README.md Outdated
@libinta
Copy link
Copy Markdown
Collaborator Author

libinta commented Jan 12, 2024

LGTM! You'll need to run make style too.

done

Copy link
Copy Markdown
Collaborator

@sywangyi sywangyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments that won't take long to address

Comment thread examples/trl/README.md Outdated
Comment thread examples/trl/README.md Outdated
Comment thread examples/trl/README.md Outdated
@regisss regisss merged commit d944698 into main Jan 16, 2024
@regisss regisss deleted the dpo_restructure branch January 16, 2024 11:55
@regisss regisss mentioned this pull request Jan 16, 2024
3 tasks
jychen21 pushed a commit to jychen21/optimum-habana that referenced this pull request Feb 27, 2024
gplutop7 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Oct 15, 2025
… Makefile (huggingface#2229) (huggingface#635)

Co-authored-by: Grzegorz Pluto-Prondzinski <gplutopx@habana.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants