Skip to content

Fix 1st token latency time #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
regisss merged 1 commit into from
Jun 28, 2024
Merged

Fix 1st token latency time #1091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 16 additions & 17 deletions optimum/habana/transformers/generation/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1863,6 +1863,14 @@ def _greedy_search(
input_ids, scores, token_idx=cur_len, ignore_eos=ignore_eos, eos_token_id=eos_token_id
)
this_peer_finished = unfinished_sequences.max() == 0
hb_profer.step()
if hb_gen_time is not None:
if not time_to_first_token_done:
time_to_first_token_done = True
import habana_frameworks.torch.hpu as torch_hpu

torch_hpu.synchronize()
hb_gen_time.step()

if (
not model_kwargs.get("pad_done", False)
Expand All @@ -1873,14 +1881,6 @@ def _greedy_search(
# before starting the decode phase.
self._pad_past_key_values(model_kwargs)
model_kwargs["pad_done"] = True
hb_profer.step()
if hb_gen_time is not None:
if not time_to_first_token_done:
time_to_first_token_done = True
import habana_frameworks.torch.hpu as torch_hpu

torch_hpu.synchronize()
hb_gen_time.step()

if (
model_kwargs.get("use_hpu_graphs", False)
Expand Down Expand Up @@ -2282,6 +2282,14 @@ def _sample(
input_ids, scores, token_idx=cur_len, ignore_eos=ignore_eos, eos_token_id=eos_token_id
)
this_peer_finished = unfinished_sequences.max() == 0
hb_profer.step()
if hb_gen_time is not None:
if not time_to_first_token_done:
time_to_first_token_done = True
import habana_frameworks.torch.hpu as torch_hpu

torch_hpu.synchronize()
hb_gen_time.step()

if (
not model_kwargs.get("pad_done", False)
Expand All @@ -2293,15 +2301,6 @@ def _sample(
self._pad_past_key_values(model_kwargs)
model_kwargs["pad_done"] = True

hb_profer.step()
if hb_gen_time is not None:
if not time_to_first_token_done:
time_to_first_token_done = True
import habana_frameworks.torch.hpu as torch_hpu

torch_hpu.synchronize()
hb_gen_time.step()

if (
model_kwargs.get("use_hpu_graphs", False)
and model_kwargs.get("limit_hpu_graphs", False)
Expand Down