diff --git a/slurm/eval_callback.slurm b/slurm/eval_callback.slurm index 093c3d067..bec49ab96 100644 --- a/slurm/eval_callback.slurm +++ b/slurm/eval_callback.slurm @@ -8,8 +8,7 @@ set -x -e source ~/.bashrc -conda activate openr1 - +source openr1/bin/activate TASK_NAME=$1 TASKS=$2 MODEL_ID=$3 @@ -31,7 +30,7 @@ fi LM_EVAL_REPO_ID="open-r1/open-r1-eval-leaderboard" MODEL_NAME=$(echo $MODEL_ID | sed 's/\//_/g') # replaces / with _ -DETAILS_REPO_ID="open-r1//details-$MODEL_NAME" +DETAILS_REPO_ID="open-r1/details-$MODEL_NAME" OUTPUT_DIR="eval_results/$MODEL_ID/$MODEL_REVISION/$TASK_NAME" # We need this flag since we run this script from training jobs that use DeepSpeed and the env vars get progated which causes errors during evaluation ACCELERATE_USE_DEEPSPEED=false diff --git a/slurm/evaluate.slurm b/slurm/evaluate.slurm index 5fe7f8e33..0ca4a8701 100644 --- a/slurm/evaluate.slurm +++ b/slurm/evaluate.slurm @@ -14,7 +14,7 @@ set -x -e source ~/.bashrc -conda activate openr1 +source openr1/bin/activate module load cuda/12.1 echo "START TIME: $(date)" echo "PYTHON ENV: $(which python)" diff --git a/slurm/generate.slurm b/slurm/generate.slurm index c154d64af..9cc9b1cce 100644 --- a/slurm/generate.slurm +++ b/slurm/generate.slurm @@ -129,7 +129,7 @@ export LD_LIBRARY_PATH=.venv/lib/python3.11/site-packages/nvidia/nvjitlink/lib echo "SLURM_JOB_ID: $SLURM_JOB_ID" echo "SLURM_JOB_NODELIST: $SLURM_JOB_NODELIST" -source .venv/bin/activate +source openr1/bin/activate # Getting the node names nodes=$(scontrol show hostnames "$SLURM_JOB_NODELIST") diff --git a/slurm/grpo.slurm b/slurm/grpo.slurm index 419af2373..8a3d63a32 100644 --- a/slurm/grpo.slurm +++ b/slurm/grpo.slurm @@ -11,7 +11,7 @@ set -x -e source ~/.bashrc -conda activate openr1 +source openr1/bin/activate echo "START TIME: $(date)" echo "PYTHON ENV: $(which python)" diff --git a/slurm/sft.slurm b/slurm/sft.slurm index 120f8e8a2..31528cdcb 100644 --- a/slurm/sft.slurm +++ b/slurm/sft.slurm @@ -11,7 +11,7 @@ set -x -e source ~/.bashrc -conda activate openr1 +source openr1/bin/activate echo "START TIME: $(date)" echo "PYTHON ENV: $(which python)" diff --git a/src/open_r1/utils/upload_details.py b/src/open_r1/utils/upload_details.py index 273e48bdb..caa491cfa 100644 --- a/src/open_r1/utils/upload_details.py +++ b/src/open_r1/utils/upload_details.py @@ -39,7 +39,7 @@ class ScriptArguments: def main(): parser = HfArgumentParser(ScriptArguments) - args = parser.parse() + args = parser.parse_args_into_dataclasses()[0] if all(file.endswith(".json") for file in args.data_files): ds = load_dataset("json", data_files=args.data_files)