Skip to content

[DDPMScheduler] Load alpha_cumprod to device to avoid redundant data movement. #6704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiyixuxu merged 3 commits into from
Jan 30, 2024
Merged

[DDPMScheduler] Load alpha_cumprod to device to avoid redundant data movement. #6704

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95ec089
load cumprod tensor to device
woshiyyya Jan 24, 2024
6708617
fixing ci
woshiyyya Jan 30, 2024
0fbd4d4
make fix-copies
woshiyyya Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/diffusers/schedulers/scheduling_ddpm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,10 @@ def add_noise(
timesteps: torch.IntTensor,
) -> torch.FloatTensor:
# Make sure alphas_cumprod and timestep have same device and dtype as original_samples
alphas_cumprod = self.alphas_cumprod.to(device=original_samples.device, dtype=original_samples.dtype)
# Move the self.alphas_cumprod to device to avoid redundant CPU to GPU data movement
# for the subsequent add_noise calls
self.alphas_cumprod = self.alphas_cumprod.to(device=original_samples.device)
alphas_cumprod = self.alphas_cumprod.to(dtype=original_samples.dtype)
Copy link
Member

@sayakpaul sayakpaul Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am personally okay with this.

timesteps = timesteps.to(original_samples.device)

sqrt_alpha_prod = alphas_cumprod[timesteps] ** 0.5
Expand Down