Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPAdapters for FLUX pipelines #9825

Closed
2 tasks done
chenxiao111222 opened this issue Oct 31, 2024 · 10 comments · Fixed by #10261
Closed
2 tasks done

Support IPAdapters for FLUX pipelines #9825

chenxiao111222 opened this issue Oct 31, 2024 · 10 comments · Fixed by #10261
Assignees

Comments

@chenxiao111222
Copy link

Model/Pipeline/Scheduler description

IPAdapter for FLUX is available now, do you have any plans to add IPAdapter to FLUX pipelines?

Open source status

  • The model implementation is available.
  • The model weights are available (Only relevant if addition is not a scheduler).

Provide useful links for the implementation

model implementation:

model weights:

@sayakpaul
Copy link
Member

sayakpaul commented Nov 1, 2024

Cc: @asomoza

#9787

@hj13-mtlab
Copy link

@sayakpaul flux ip adapter error, 'FluxTransformer2DModel' object has no attribute 'encoder_hid_proj'

@vladmandic
Copy link
Contributor

@sayakpaul @yiyixuxu @asomoza as requested yesterday in a discussion, tagging this as a high-priority ask.
(if you'd prefer to use a different mechanism for tagging, let me know)

@sayakpaul
Copy link
Member

sayakpaul commented Nov 18, 2024

Thanks for doing that, appreciated!

Last time I checked with @asomoza regarding this, the conclusion was the results aren't as promising but things may have changed. So, I will let @asomoza to comment further here.

@asomoza
Copy link
Member

asomoza commented Nov 18, 2024

the v2 seems to be a lot better, the v1 has more downloads though, even though I don't see that much generations with IP Adapter, we should probably add it now since it seems better and Flux is still very popular.

I'll do some test with it but I'm guessing the reason why isn't used that much its because of the VRAM requirement, same as controlnets.

I'll take a look at the PR and see how much is needed to add it, but in the meantime let's open it up to the community if someone wants to take it.

@asomoza asomoza added help wanted Extra attention is needed contributions-welcome labels Nov 18, 2024
@asomoza asomoza self-assigned this Nov 18, 2024
@peki12345
Copy link

the v2 seems to be a lot better, the v1 has more downloads though, even though I don't see that much generations with IP Adapter, we should probably add it now since it seems better and Flux is still very popular.

I'll do some test with it but I'm guessing the reason why isn't used that much its because of the VRAM requirement, same as controlnets.

I'll take a look at the PR and see how much is needed to add it, but in the meantime let's open it up to the community if someone wants to take it.

Hi, may I ask if implementing flux IP adapter, can it support IP adapters with a given mask like SDXL? I think this is a very practical feature. I haven't seen similar functionality in other frameworks like ComfyUI, it seems to be unique to diffusers.

@yiyixuxu
Copy link
Collaborator

cc @fabiorigano here

@asomoza
Copy link
Member

asomoza commented Nov 19, 2024

Hi, may I ask if implementing flux IP adapter, can it support IP adapters with a given mask like SDXL? I think this is a very practical feature. I haven't seen similar functionality in other frameworks like ComfyUI, it seems to be unique to diffusers.

Of course, when we add it, it should have the same functionality as the other ones. The ComfyUI ones also have this though and actually we used the ComfyUI implementation as a reference.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Dec 14, 2024
@vladmandic
Copy link
Contributor

ping.

@github-actions github-actions bot removed the stale Issues that haven't received updates label Dec 15, 2024
@hlky hlky added the roadmap Add to current release roadmap label Dec 16, 2024
@hlky hlky added the wip label Dec 16, 2024
@hlky hlky moved this to In Progress in Diffusers Roadmap 0.33 Dec 16, 2024
@hlky hlky removed the roadmap Add to current release roadmap label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants