Skip to content

Commit e74f802

Browse files
mariosaskolhoestq
andauthored
Reduce the number of commits in push_to_hub (#6269)
* Test single commit `push_to_hub` API * Address review comments * Fix * Cleaner implementation * Tests * Fixes and more tests * Remove comment * Apply suggestions from code review Co-authored-by: Quentin Lhoest <[email protected]> * Split push in multiple commits * Fix test * Apply suggestions from code review Co-authored-by: Quentin Lhoest <[email protected]> * Fix type hint and style * Oops :) * Log commit number * Apply suggestions from code review Co-authored-by: Quentin Lhoest <[email protected]> * Add logging messages to DatasetDict --------- Co-authored-by: Quentin Lhoest <[email protected]>
1 parent 3e8d420 commit e74f802

File tree

6 files changed

+439
-444
lines changed

6 files changed

+439
-444
lines changed

.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ jobs:
6464
run: pip install --upgrade pyarrow huggingface-hub dill
6565
- name: Install depencencies (minimum versions)
6666
if: ${{ matrix.deps_versions != 'deps-latest' }}
67-
run: pip install pyarrow==8.0.0 huggingface-hub==0.14.0 transformers dill==0.3.1.1
67+
run: pip install pyarrow==8.0.0 huggingface-hub==0.18.0 transformers dill==0.3.1.1
6868
- name: Test with pytest
6969
run: |
7070
python -m pytest -rfExX -m ${{ matrix.test }} -n 2 --dist loadfile -sv ./tests/

setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@
131131
"aiohttp",
132132
# To get datasets from the Datasets Hub on huggingface.co
133133
# minimum 0.14.0 to support HfFileSystem
134-
"huggingface-hub>=0.14.0,<1.0.0",
134+
"huggingface_hub>=0.18.0",
135135
# Utilities from PyPA to e.g., compare versions
136136
"packaging",
137137
# To parse YAML metadata from dataset cards

0 commit comments

Comments
 (0)