Optimize the cat operation on contiguous tensors #1855
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dedicated kernel for efficiently doing the copy in this case.
Benchmarks
Concatenating a (1, 32, 2000, 128) tensor with a (1, 32, 1, 128) one which is typical for a kv-cache operation.
Using a q4k quantized llama 7b model, generating a 1k sequence.
Ideally this would use
cudaMemcpy2don the cuda side rather than the current kernel which does a division. Another possibility would be to have specialized kernels for common shapes (e.g. powers of 2 for d2).