Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google.coffee is broken #1024

Closed
n0mer opened this issue Aug 11, 2015 · 4 comments
Closed

google.coffee is broken #1024

n0mer opened this issue Aug 11, 2015 · 4 comments

Comments

@n0mer
Copy link

n0mer commented Aug 11, 2015

https://github.com/github/hubot-scripts/blob/master/src/scripts/google.coffee

Always returns "Sorry, Google had zero results".

Is there any way to disable this script? Or remove it completely.

@kengz
Copy link

kengz commented Aug 12, 2015

You can replace it with your own script. I realized the same issue and rewrote it, you can use too :)
here: https://github.com/kengz/jarvis
under scripts/google.coffee

@technicalpickles
Copy link
Member

@n0mer you can remove "google.coffee" from your hubot-scripts.json.

You can also try using https://github.com/mnpk/hubot-google , which is an updated version of it. @kengz you might find that useful too.

@n0mer
Copy link
Author

n0mer commented Aug 13, 2015

@technicalpickles i override this script with google.coffee from https://github.com/kengz/jarvis

what about removing broken google.coffee from Hubot distribution?

@technicalpickles
Copy link
Member

I'd happily accept a PR to do just that 😁 That said, we are trying to kill that repository over in github/hubot-scripts#1641 and get people using scripts that have been packaged separately.

For that reason, I'd recommend using https://github.com/mnpk/hubot-google instead of just copying from jarvis. Otherwise, you'll have to keep copying down changes from that repository, rather than just updating the package cc @kengz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants