Skip to content

Design system page section #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Apr 8, 2025
Merged

Design system page section #1009

merged 33 commits into from
Apr 8, 2025

Conversation

edlu77
Copy link
Contributor

@edlu77 edlu77 commented Mar 24, 2025 •
edited
Loading

@edlu77 edlu77 requested review from axdanbol and LibbyUX March 24, 2025 23:31
@edlu77 edlu77 self-assigned this Mar 24, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 24, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit d1cdeea.

Command Status Duration Result
nx affected --targets=build-storybook --configu... ✅ Succeeded 56s View ↗
nx affected --targets=compodoc --configuration=ci ✅ Succeeded 4s View ↗
nx affected --targets=build-webcomponent --conf... ✅ Succeeded 1s View ↗
nx affected --targets=build --configuration=pre... ✅ Succeeded 3m 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-08 14:50:56 UTC

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 24, 2025 •
edited
Loading

🚀 Preview Deploy Report Updated

✅ Successfully deployed preview here

LibbyUX
LibbyUX reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@LibbyUX LibbyUX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edlu77 !

Thank you for meeting with me earlier! Below are my notes from our meeting and changes that are live in Figma:

Product logo component and organ icon components

  • Updated both of these components to 64px by 64px in the Page Label component instead of 80px by 80px as originally specified.
  • Updated the implementation size of the icon within the branded product and organ component to be 60% of the 64px by 64px size (38.4px by 38.4px). This is a design system update that I encourage to be applied in Storybook for both the product logo component and the organ icon logo component.
  • Updated spacing between product icon and organ icon updated to 12px instead of 16px as originally specified.
  • We added our Specialty Style/HRA Red hex FF0043 to our styles in Storybook for the Organ Icon Logo component. This color is also used in the HRA logo.
  • The spacing in the page label component between branded iconography components and the page label initially was 24px. We updated this spacing to 16px.

Design system font styles update

  • Per stakeholder feedback, we removed the spacing between letters in all Nunito Sans "Body" font sizes.

Thank you for adjusting these in our design system and iterating with me! Please let me know if you have any questions!

This was linked to issues Mar 25, 2025
Add Section Link #972
Closed
Add page section #1006
Closed
Update product logo assets #979
Closed
@axdanbol axdanbol changed the base branch from hra-portal-update to develop March 25, 2025 21:21
@axdanbol axdanbol changed the base branch from develop to hra-portal-update March 25, 2025 21:21
@axdanbol axdanbol changed the base branch from hra-portal-update to develop March 25, 2025 21:23
@axdanbol axdanbol changed the base branch from develop to hra-portal-update March 25, 2025 21:57
@LibbyUX LibbyUX mentioned this pull request Mar 26, 2025
Closed
@LibbyUX LibbyUX linked an issue Mar 26, 2025 that may be closed by this pull request
Update product logo component: Organ Gallery #959
Closed
@LibbyUX LibbyUX mentioned this pull request Mar 26, 2025
Closed
8 tasks
@edlu77
Copy link
Contributor Author

edlu77 commented Mar 26, 2025 •
edited
Loading

@LibbyUX Font updates will be addressed by #1014

Product logo asset updates will be addressed by #1013

@edlu77 edlu77 mentioned this pull request Mar 28, 2025
Open
LibbyUX
LibbyUX approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@LibbyUX LibbyUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect - Approved. I reviewed the functionality on desktop and mobile at https://67e6fb57e1d81000bd01afdc--hra-ui.netlify.app/storybook/design-system/iframe.html?viewMode=story&id=design-system-content-template-pagenavigation--primary&globals=backgrounds.grid%3A!false&args=#page-label.

Stellar! Thank you so much @edlu77 !

axdanbol and others added 13 commits April 3, 2025 10:51
@axdanbol
Merge branch 'hra-portal-update' into Design-system-page-section
15f8907
@axdanbol
refactor(lib:design-system): 🔥 Remove duplicate assets
bf7dbad
@axdanbol
refactor(lib:design-system): 🚚 Rename content-template -> content-tem…
67497fe 
…plates
@axdanbol
refactor(lib:design-system): Turn content-templates into an entrypoint
d95ec6a
@edlu77
Add missing documentation
c8eb813
@edlu77
Merge branch 'hra-portal-update' of https://github.com/hubmapconsorti…
3e5caca 
…um/hra-ui into Design-system-page-section
@edlu77
Add organ logos component
c886e83
@edlu77
Refactor section link and page section
bc29e1f
@edlu77
Add page label component
e7af1af
@edlu77
Add website category logos
8390d7d
@edlu77
Documentation and tweaks
0513cc8
@edlu77
Merge branch 'hra-portal-update' of https://github.com/hubmapconsorti…
f6b293b 
…um/hra-ui into Design-system-page-section
@edlu77
Tweaks
d1cdeea
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@axdanbol axdanbol merged commit 9607fd2 into hra-portal-update Apr 8, 2025
9 checks passed
@axdanbol axdanbol deleted the Design-system-page-section branch April 8, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axdanbol axdanbol axdanbol approved these changes

@LibbyUX LibbyUX LibbyUX approved these changes

Assignees

@edlu77 edlu77

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@edlu77 @axdanbol @LibbyUX