-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHEvent is missing new events that is breaking Jenkins plugin usage #1234
Comments
It seems that release https://github.com/hub4j/github-api/releases/tag/github-api-1.128 may have actually introduce UNKNOWN GHEvent enum handling but the jenkins github-api-plugin is at version 122 My PR might not be needed if release 1.128 was meant to resolve this issue |
@bitwiseman considering the above I'm not sure what I need to be doing to resolve this issue. What is the process for releasing the jenkins github-api-plugin (https://github.com/jenkinsci/github-api-plugin)? |
You need to wait for jenkinsci/github-api-plugin#109 to be green then merge and release. Could be done today. |
Ok that's great hopefully this resolves our issue. I'll keep an eye on this and test it as soon as its live. Thanks @bitwiseman |
@bitwiseman saw that the PR was merged, is the release in progress? I don't see a new tag yet in https://github.com/jenkinsci/github-api-plugin |
I'm on leave right now, working on this in my spare time (from my phone right now). I'll get to it today. |
Sorry for the trouble and thank you for keeping an eye on this |
I've released github-api-plugin 1.133. That should unblock you. I've also merged your PR. It will be in 1.134 . Thanks for contributing! |
Yes its working and we are unblocked! Thanks @bitwiseman for helping us get through this quickly and closing my PR |
Describe the bug
Getting error:
When trying to connect to github app from jenkins.
To Reproduce
Test
to test the connectionExpected behavior
Jenkins Github App Connectivity should work with new events
Desktop (please complete the following information):
Additional context
Create this PR with possible fix and more info #1233
Creating this issue as I was unsure if the PR was enough and also for visibility
The text was updated successfully, but these errors were encountered: