Merge pull request #2036 from rnveach/unused_exceptions

Removed unused checked exceptions

Author: bitwiseman

pom.xml

@@ -383,16 +383,8 @@
         <artifactId>japicmp-maven-plugin</artifactId>
         <version>0.23.0</version>
         <configuration>
-          <oldVersion>
-            <dependency>
-              <groupId>${project.groupId}</groupId>
-              <artifactId>${project.artifactId}</artifactId>
-              <version>2.0.0-alpha-1</version>
-              <type>jar</type>
-            </dependency>
-          </oldVersion>
           <parameter>
-            <breakBuildOnBinaryIncompatibleModifications>true</breakBuildOnBinaryIncompatibleModifications> -->
+            <breakBuildOnBinaryIncompatibleModifications>true</breakBuildOnBinaryIncompatibleModifications>
             <!-- <breakBuildBasedOnSemanticVersioning>true</breakBuildBasedOnSemanticVersioning> -->
             <onlyModified>true</onlyModified>
             <includeSynthetic>true</includeSynthetic>

src/main/java/org/kohsuke/github/GHAppInstallationToken.java

@@ -1,6 +1,5 @@
 package org.kohsuke.github;
 
-import java.io.IOException;
 import java.util.*;
 
 // TODO: Auto-generated Javadoc
@@ -66,10 +65,8 @@ public GHRepositorySelection getRepositorySelection() {
      * Gets expires at.
      *
      * @return date when this token expires
-     * @throws IOException
-     *             on error
      */
-    public Date getExpiresAt() throws IOException {
+    public Date getExpiresAt() {
         return GitHubClient.parseDate(expires_at);
     }
 }

src/main/java/org/kohsuke/github/GHBranch.java

@@ -34,11 +34,9 @@ public class GHBranch extends GitHubInteractiveObject {
      *
      * @param name
      *            the name
-     * @throws Exception
-     *             the exception
      */
     @JsonCreator
-    GHBranch(@JsonProperty(value = "name", required = true) String name) throws Exception {
+    GHBranch(@JsonProperty(value = "name", required = true) String name) {
         Objects.requireNonNull(name);
         this.name = name;
     }

src/main/java/org/kohsuke/github/GHCommit.java

@@ -520,10 +520,8 @@ public PagedIterable<GHPullRequest> listPullRequests() {
      * Retrieves a list of branches where this commit is the head commit.
      *
      * @return {@link PagedIterable} with the branches where the commit is the head commit
-     * @throws IOException
-     *             the io exception
      */
-    public PagedIterable<GHBranch> listBranchesWhereHead() throws IOException {
+    public PagedIterable<GHBranch> listBranchesWhereHead() {
         return owner.root()
                 .createRequest()
                 .withUrlPath(String.format("/repos/%s/%s/commits/%s/branches-where-head",

src/main/java/org/kohsuke/github/GHCommitPointer.java

@@ -49,11 +49,9 @@ public GHCommitPointer() {
      * This points to the user who owns the {@link #getRepository()}.
      *
      * @return the user
-     * @throws IOException
-     *             the io exception
      */
     @SuppressFBWarnings(value = { "EI_EXPOSE_REP" }, justification = "Expected behavior")
-    public GHUser getUser() throws IOException {
+    public GHUser getUser() {
         if (user != null)
             return user.root().intern(user);
         return user;

src/main/java/org/kohsuke/github/GHCommitStatus.java

@@ -1,7 +1,5 @@
 package org.kohsuke.github;
 
-import java.io.IOException;
-
 // TODO: Auto-generated Javadoc
 /**
  * Represents a status of a commit.
@@ -69,10 +67,8 @@ public String getDescription() {
      * Gets creator.
      *
      * @return the creator
-     * @throws IOException
-     *             the io exception
      */
-    public GHUser getCreator() throws IOException {
+    public GHUser getCreator() {
         return root().intern(creator);
     }
 

src/main/java/org/kohsuke/github/GHContent.java

@@ -257,10 +257,8 @@ protected synchronized void populate() throws IOException {
      * List immediate children of this directory.
      *
      * @return the paged iterable
-     * @throws IOException
-     *             the io exception
      */
-    public PagedIterable<GHContent> listDirectoryContent() throws IOException {
+    public PagedIterable<GHContent> listDirectoryContent() {
         if (!isDirectory())
             throw new IllegalStateException(path + " is not a directory");
 

src/main/java/org/kohsuke/github/GHDeployment.java

@@ -1,6 +1,5 @@
 package org.kohsuke.github;
 
-import java.io.IOException;
 import java.net.URL;
 import java.util.Collections;
 import java.util.Map;
@@ -169,10 +168,8 @@ public boolean isProductionEnvironment() {
      * Gets creator.
      *
      * @return the creator
-     * @throws IOException
-     *             the io exception
      */
-    public GHUser getCreator() throws IOException {
+    public GHUser getCreator() {
         return root().intern(creator);
     }
 

src/main/java/org/kohsuke/github/GHDiscussion.java

@@ -36,10 +36,8 @@ public GHDiscussion() {
      * Gets the html url.
      *
      * @return the html url
-     * @throws IOException
-     *             Signals that an I/O exception has occurred.
      */
-    public URL getHtmlUrl() throws IOException {
+    public URL getHtmlUrl() {
         return GitHubClient.parseURL(htmlUrl);
     }
 
@@ -122,10 +120,8 @@ public boolean isPrivate() {
      * @param team
      *            the team in which the discussion will be created.
      * @return a {@link GHLabel.Creator}
-     * @throws IOException
-     *             the io exception
      */
-    static GHDiscussion.Creator create(GHTeam team) throws IOException {
+    static GHDiscussion.Creator create(GHTeam team) {
         return new GHDiscussion.Creator(team);
     }
 
@@ -154,10 +150,8 @@ static GHDiscussion read(GHTeam team, long discussionNumber) throws IOException
      * @param team
      *            the team
      * @return the paged iterable
-     * @throws IOException
-     *             Signals that an I/O exception has occurred.
      */
-    static PagedIterable<GHDiscussion> readAll(GHTeam team) throws IOException {
+    static PagedIterable<GHDiscussion> readAll(GHTeam team) {
         return team.root()
                 .createRequest()
                 .setRawUrlPath(getRawUrlPath(team, null))

src/main/java/org/kohsuke/github/GHEventInfo.java

@@ -162,10 +162,8 @@ public GHUser getActor() throws IOException {
      * Gets actor login.
      *
      * @return the login of the actor.
-     * @throws IOException
-     *             on error
      */
-    public String getActorLogin() throws IOException {
+    public String getActorLogin() {
         return actor.getLogin();
     }