Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix traffic histories script #2006

Merged
merged 1 commit into from
May 1, 2023
Merged

Fix traffic histories script #2006

merged 1 commit into from
May 1, 2023

Conversation

saulfield
Copy link
Contributor

@saulfield saulfield commented May 1, 2023 •
edited
Loading

Fixes #2005.

It looks like a change got through that reassigned the agent interface variable.

qianyi-sun
qianyi-sun reviewed May 1, 2023
View reviewed changes
Copy link
Contributor

@qianyi-sun qianyi-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented this line out on my branch, script doesnt crash anymore but cannot find any vehicle id in the scenario

@saulfield
Copy link
Contributor Author

It seems to be working for me. Can you show me the scenario and command you are running with?

@saulfield saulfield merged commit 275bfdb into master May 1, 2023
@saulfield saulfield deleted the saul/traffic-histories-script-fix branch May 1, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qianyi-sun qianyi-sun qianyi-sun approved these changes

@Gamenot Gamenot Gamenot approved these changes

@Adaickalavan Adaickalavan Awaiting requested review from Adaickalavan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report] traffic_histories_to_observations.py crashes
3 participants
@saulfield @Gamenot @qianyi-sun