Fix waypoints in SUMO junctions #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adaickalavan
approved these changes
Mar 24, 2023
Gamenot
reviewed
Mar 24, 2023
Comment on lines
+979
to
+980
| for incoming_lane in lane.incoming_lanes: | ||
| for junction_lane in incoming_lane.outgoing_lanes: |
There was a problem hiding this comment.
This may or may not be enough, I remember that sometimes the junction lanes are subdivided so that the incoming lane is still a junction lane. You may want to do a in_junction check to get back to an incoming lane that is not in the junction.
There was a problem hiding this comment.
Good to know. Should we hold off on merging this until we test it a bit more? I think this change will only help.
There was a problem hiding this comment.
After previous conversation, we can merge this and consider future fixes with other PRs.
Gamenot
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1911.
See this comment for context. I'm opening a PR for this because it appears to be separate from the other waypoint issues that have been reported.