-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate waymo_open_dataset dependency #1905
Conversation
I am cautious about naming the package the same as the original. It might cause a package conflict. |
I agree in general, but in this case I think it's ok. It makes it easier since we don't have to modify any of the protos or generated files to make the imports work, and since the waymo package is incompatible with smarts anyway there isn't a risk of them being installed in the same venv. |
OK. |
Some thoughts on presenting SMARTS support for external datasets. We could address this in a separate PR too. Consider updating how to use SMARTS for Waymo in ReadTheDocs::Ecosystem::Waymo. In ReadTheDocs::Example::Naturalistic section we could provide intructions We could move readmes such as (i) |
I moved the I also updated the Waymo section of the docs, and deleted the README in the waymo example scenario. |
Fixes #1880