Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Argoverse 2 Motion Forecasting Dataset #1893

Merged
merged 34 commits into from
Mar 17, 2023
Merged

Conversation

saulfield
Copy link
Contributor

Closes #1865.

  • Added ArgoverseMap class
  • Added Argoverse class in genhistories.py for traffic history replay
  • Generalized GLB methods across map implementations

.github/workflows/ci-base-tests-linux.yml Show resolved Hide resolved
smarts/sstudio/genhistories.py Outdated Show resolved Hide resolved
smarts/core/lanepoints.py Show resolved Hide resolved
smarts/core/utils/glb.py Outdated Show resolved Hide resolved
smarts/core/argoverse_map.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Adaickalavan
Copy link
Member

Adaickalavan commented Mar 13, 2023

Consider putting up an example, in the example folder, on using Argoverse map and traffic. Add the Argoverse example to the CI tests. Update how to use SMARTS for Argoverse under Ecosystem section in ReadTheDocs.

@qianyi-sun
Copy link
Contributor

When we finish adding color configuration for those actors, maybe we could consider giving the is_ego_vehicle a different color?

@saulfield
Copy link
Contributor Author

Consider putting up an example, in the example folder, on using Argoverse map and traffic. Add the Argoverse example to the CI tests. Update how to use SMARTS for Argoverse under Ecosystem section in ReadTheDocs.

There is an example scenario in this PR that uses an Argoverse map and traffic histories that should work with any example. Is there something you had in mind that is not covered by that?

It would be good to have some tests, but I was unsure if the license allowed us to host the dataset files.

I will update ReadTheDocs -- thanks for the reminder.

@Adaickalavan
Copy link
Member

With regards to the Argoverse example, we could do something similar to the suggestion for Waymo example at #1905 (comment) .

@saulfield
Copy link
Contributor Author

With regards to the Argoverse example, we could do something similar to the suggestion for Waymo example at #1905 (comment) .

I have added an Argoverse section to ReadTheDocs, with instructions for running an example scenario and a gif of the expected visualization. I opted not to create a new example script as this didn't seem necessary.

@saulfield saulfield merged commit a8776ed into master Mar 17, 2023
@saulfield saulfield deleted the argoverse branch March 17, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Argoverse 2
4 participants