Add reset options to "hiway-v1". #1862
Conversation
| @property | ||
| def smarts(self): | ||
| """Gives access to the underlying simulator. Use this carefully. | ||
|
|
||
| Returns: | ||
| smarts.core.smarts.SMARTS: The smarts simulator instance. | ||
| """ | ||
| return self._smarts |
There was a problem hiding this comment.
Considering we have previously provided def scenario(), what is the use case for additionally providing def smarts()?
There was a problem hiding this comment.
Generally just for direct access to SMARTS, I am somewhat cautious about allowing this but if we do not allow it there may be little exposure to actually using SMARTS directly.
I am partially hoping people will be tempted to use it.
| observation_options="unformatted", | ||
| headless=True, | ||
| visdom=False, | ||
| fixed_timestep_sec=0.01, |
There was a problem hiding this comment.
Maybe we should simply make the fixed_timestep_sec=0.01 as the default value in HiWayEnvV1.
There was a problem hiding this comment.
Why 0.01? The fixed time-step for the environment is 0.1 if not already given.
| scenarios = ["scenarios/sumo/loop"] | ||
| scenario: Scenario = next(Scenario.scenario_variations(scenarios, [AGENT_ID])) | ||
|
|
||
| env.reset(options={"scenario": scenario, "start_time": 100}) | ||
| assert "loop" in env.scenario.root_filepath |
There was a problem hiding this comment.
Given the env originally only had one scenario, namely scenarios/sumo/loop, testing reset functionality by resetting to the same scenario might be an insufficient test. We could try resetting the env to a different scenario to check whether the functionality works.
There was a problem hiding this comment.
Right I was grabbing something quick, I will try "cloverleaf".
There was a problem hiding this comment.
Used figure_eight.
| assert not (agent_ids - set(env.agent_interfaces)) | ||
| matching_items = [ | ||
| env.agent_interfaces[k] == agent_interfaces[k] | ||
| for k in env.agent_interfaces | ||
| if k in agent_interfaces | ||
| ] | ||
| assert all(matching_items) | ||
| assert len(env.agent_interfaces) == len(agent_interfaces) | ||
| assert not (agent_ids - env.agent_ids) |
There was a problem hiding this comment.
Wondering whether these checks could be simplified.
There was a problem hiding this comment.
I also note that these checks should not be in the fixture. I am moving and simplifying them.
See CHANGELOG.md