Suppress the DeprecationWarning caused by the trimesh package
#1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulfield
approved these changes
Dec 14, 2022
smarts/core/scenario.py
Outdated
Comment on lines
71
to
73
| with warnings.catch_warnings(): | ||
| warnings.filterwarnings("ignore", category=DeprecationWarning) | ||
| import trimesh # only suppress the warnings caused by trimesh |
There was a problem hiding this comment.
- Does the catch warning also cater to
import trimeshin other files, such asopendrive_road_network.py,sumo_road_network.py,waymo_map.py, andgeometry.py? - Can catch warning be implemented inside
map_glb_meta_for_file()method below in this file wheretrimeshis being imported?
There was a problem hiding this comment.
@qianyi-sun Could you make the warning more specific? It is possible to pattern match warnings to ignore.
There was a problem hiding this comment.
@Adaickalavan I checked running waymo/opendrive/sumo scenarios, seems like the warning is gone in all three type of scenarios.
@Gamenot If I understood "specfic" correctly, I just added a message= option in the warnings.filterwarning to only suppress this specific message.
There was a problem hiding this comment.
Yes, that is what I meant.
Adaickalavan
approved these changes
Dec 15, 2022
Gamenot
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress the
/root/SMARTS/.venv/lib/python3.8/site-packages/trimesh/curvature.py:12: DeprecationWarning: Please use `coo_matrix` from the `scipy.sparse` namespace, the `scipy.sparse.coo` namespace is deprecated.warning.