Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Ensure environment spaces checks pass #2072

Open
Gamenot opened this issue Jun 24, 2023 · 0 comments
Open

[Feature request] Ensure environment spaces checks pass #2072

Gamenot opened this issue Jun 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Gamenot
Copy link
Collaborator

Gamenot commented Jun 24, 2023

Motivation

The "hiway-v1" and RLlibHiWayEnv environments currently do not pass the environment checkers and should to make the configuration easier.

Proposal

Run fixes on the hiway-v0 environment so that the following should pass:

gymnasium.envs.registration.make(HiWayEnvV1, disable_env_checker=False)
ray.rllib.utils.check_env(RLlibHiWayEnv())

The cause of the issue with RLlibHiWayEnv is that the agent observation and action adaptors need to contain spaces and override the observation and action space of the environment. These adaptors should be removed from the agent spec and added as environment parameters.

The cause of the issue with the environments in make is that when using ObservationSpacesFormatter.unformatted or ActionSpacesFormatter.unformatted the generated action space is None.

Alternatives

No response

Additional context

No response

@Gamenot Gamenot added the enhancement New feature or request label Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant